soul-browser/app/smali_classes3/com/google/gson/internal/reflect/ReflectionHelper.smali
KaKi87 550ddb0413
Decompile and recreate Soul Browser v1.4.85 with APK CI builds (#1)
* Decompile and recreate Soul Browser v1.4.85 with APK CI builds

Co-authored-by: KaKi87 <KaKi87@pm.me>

* Fix CI build: include bundled google.jks and remove PR trigger

The apktool build failed in CI because app/unknown/.../google.jks was
excluded by the *.jks gitignore rule. Whitelist app-bundled JKS files
and commit the missing resource.

Also remove the redundant pull_request workflow trigger.

Co-authored-by: KaKi87 <KaKi87@pm.me>

* Change package ID to com.github.kaki87.soulbrowser

Rename the application ID so the rebuilt APK can be installed
alongside the original Soul Browser from Google Play.

- Update AndroidManifest package, permissions, providers, and actions
- Update R class references in smali (com/github/kaki87/soulbrowser/R)
- Update shortcuts.xml targetPackage
- Rename app label to "Soul Rebuild" for easy identification

Co-authored-by: KaKi87 <KaKi87@pm.me>

* Fix install compatibility: remove split APK metadata and bundle native libs

The rebuilt APK still declared requiredSplitTypes and Play Store split
metadata, causing Android to reject standalone installs as incompatible.

- Remove requiredSplitTypes and split-related manifest meta-data
- Merge native libs from all ABI splits with uncompressed storage
- Page-align before signing for extractNativeLibs=false
- Add .so to apktool doNotCompress list

Co-authored-by: KaKi87 <KaKi87@pm.me>

* Fix install failure: use apksigner v2/v3 and bundle arm64 native libs

Target SDK 36 requires APK Signature Scheme v2+, but jarsigner only
produces v1 signatures, causing Android to reject the install.

- Sign with apksigner (v1+v2+v3) instead of jarsigner
- Add arm64-v8a native libraries from universal Soul Browser 1.4.79
- Set extractNativeLibs=true for reliable sideload installs
- Commit stable debug keystore for consistent signatures across builds

Co-authored-by: KaKi87 <KaKi87@pm.me>

* Add committed debug keystore for consistent APK signatures

Co-authored-by: KaKi87 <KaKi87@pm.me>

* Fix startup crash: use original classes2.dex desugar libraries

Apktool recompiles smali_classes2 into a broken classes2.dex, causing
ClassNotFoundException for j$.com.android.tools.r8.a at ML Kit init.

Inject the original classes2.dex (Java 8+ desugar libs) after apktool
build instead of using the recompiled version.

Co-authored-by: KaKi87 <KaKi87@pm.me>

* Fix missing drawable resources from density split APKs

The base APK is an app bundle module; density-specific drawables like
seek_thumb_nor_b live in config.xhdpi.apk and were missing after rebuild,
causing Resources$NotFoundException at runtime.

- Merge non-9-patch resources from split APKs before apktool build
- Sync public.xml IDs from R smali only when backing files exist
- Add 713 density-specific resource IDs to public.xml

Co-authored-by: KaKi87 <KaKi87@pm.me>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-08-10 16:07:14 +02:00

909 lines
19 KiB
Smali

.class public Lcom/google/gson/internal/reflect/ReflectionHelper;
.super Ljava/lang/Object;
.source "SourceFile"
# annotations
.annotation system Ldalvik/annotation/MemberClasses;
value = {
Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;,
Lcom/google/gson/internal/reflect/ReflectionHelper$RecordSupportedHelper;,
Lcom/google/gson/internal/reflect/ReflectionHelper$RecordNotSupportedHelper;
}
.end annotation
# static fields
.field public static final a:Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;
# direct methods
.method static constructor <clinit>()V
.locals 1
.line 1
:try_start_0
new-instance v0, Lcom/google/gson/internal/reflect/ReflectionHelper$RecordSupportedHelper;
.line 2
.line 3
invoke-direct {v0}, Lcom/google/gson/internal/reflect/ReflectionHelper$RecordSupportedHelper;-><init>()V
:try_end_0
.catch Ljava/lang/ReflectiveOperationException; {:try_start_0 .. :try_end_0} :catch_0
.line 4
.line 5
.line 6
goto :goto_0
.line 7
:catch_0
new-instance v0, Lcom/google/gson/internal/reflect/ReflectionHelper$RecordNotSupportedHelper;
.line 8
.line 9
invoke-direct {v0}, Ljava/lang/Object;-><init>()V
.line 10
.line 11
.line 12
:goto_0
sput-object v0, Lcom/google/gson/internal/reflect/ReflectionHelper;->a:Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;
.line 13
.line 14
return-void
.end method
.method public static a(Ljava/lang/reflect/AccessibleObject;Ljava/lang/StringBuilder;)V
.locals 2
.line 1
const/16 v0, 0x28
.line 2
.line 3
invoke-virtual {p1, v0}, Ljava/lang/StringBuilder;->append(C)Ljava/lang/StringBuilder;
.line 4
.line 5
.line 6
instance-of v0, p0, Ljava/lang/reflect/Method;
.line 7
.line 8
if-eqz v0, :cond_0
.line 9
.line 10
check-cast p0, Ljava/lang/reflect/Method;
.line 11
.line 12
invoke-virtual {p0}, Ljava/lang/reflect/Method;->getParameterTypes()[Ljava/lang/Class;
.line 13
.line 14
.line 15
move-result-object p0
.line 16
goto :goto_0
.line 17
:cond_0
check-cast p0, Ljava/lang/reflect/Constructor;
.line 18
.line 19
invoke-virtual {p0}, Ljava/lang/reflect/Constructor;->getParameterTypes()[Ljava/lang/Class;
.line 20
.line 21
.line 22
move-result-object p0
.line 23
:goto_0
const/4 v0, 0x0
.line 24
:goto_1
array-length v1, p0
.line 25
if-ge v0, v1, :cond_2
.line 26
.line 27
if-lez v0, :cond_1
.line 28
.line 29
const-string v1, ", "
.line 30
.line 31
invoke-virtual {p1, v1}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 32
.line 33
.line 34
:cond_1
aget-object v1, p0, v0
.line 35
.line 36
invoke-virtual {v1}, Ljava/lang/Class;->getSimpleName()Ljava/lang/String;
.line 37
.line 38
.line 39
move-result-object v1
.line 40
invoke-virtual {p1, v1}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 41
.line 42
.line 43
add-int/lit8 v0, v0, 0x1
.line 44
.line 45
goto :goto_1
.line 46
:cond_2
const/16 p0, 0x29
.line 47
.line 48
invoke-virtual {p1, p0}, Ljava/lang/StringBuilder;->append(C)Ljava/lang/StringBuilder;
.line 49
.line 50
.line 51
return-void
.end method
.method public static b(Ljava/lang/reflect/Constructor;)Ljava/lang/String;
.locals 2
.line 1
new-instance v0, Ljava/lang/StringBuilder;
.line 2
.line 3
invoke-virtual {p0}, Ljava/lang/reflect/Constructor;->getDeclaringClass()Ljava/lang/Class;
.line 4
.line 5
.line 6
move-result-object v1
.line 7
invoke-virtual {v1}, Ljava/lang/Class;->getName()Ljava/lang/String;
.line 8
.line 9
.line 10
move-result-object v1
.line 11
invoke-direct {v0, v1}, Ljava/lang/StringBuilder;-><init>(Ljava/lang/String;)V
.line 12
.line 13
.line 14
invoke-static {p0, v0}, Lcom/google/gson/internal/reflect/ReflectionHelper;->a(Ljava/lang/reflect/AccessibleObject;Ljava/lang/StringBuilder;)V
.line 15
.line 16
.line 17
invoke-virtual {v0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 18
.line 19
.line 20
move-result-object p0
.line 21
return-object p0
.end method
.method public static c(Ljava/lang/reflect/Field;)Ljava/lang/String;
.locals 2
.line 1
new-instance v0, Ljava/lang/StringBuilder;
.line 2
.line 3
invoke-direct {v0}, Ljava/lang/StringBuilder;-><init>()V
.line 4
.line 5
.line 6
invoke-virtual {p0}, Ljava/lang/reflect/Field;->getDeclaringClass()Ljava/lang/Class;
.line 7
.line 8
.line 9
move-result-object v1
.line 10
invoke-virtual {v1}, Ljava/lang/Class;->getName()Ljava/lang/String;
.line 11
.line 12
.line 13
move-result-object v1
.line 14
invoke-virtual {v0, v1}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 15
.line 16
.line 17
const-string v1, "#"
.line 18
.line 19
invoke-virtual {v0, v1}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 20
.line 21
.line 22
invoke-virtual {p0}, Ljava/lang/reflect/Field;->getName()Ljava/lang/String;
.line 23
.line 24
.line 25
move-result-object p0
.line 26
invoke-virtual {v0, p0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 27
.line 28
.line 29
invoke-virtual {v0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 30
.line 31
.line 32
move-result-object p0
.line 33
return-object p0
.end method
.method public static d(Ljava/lang/reflect/AccessibleObject;Z)Ljava/lang/String;
.locals 4
.line 1
instance-of v0, p0, Ljava/lang/reflect/Field;
.line 2
.line 3
const-string v1, "\'"
.line 4
.line 5
if-eqz v0, :cond_0
.line 6
.line 7
new-instance v0, Ljava/lang/StringBuilder;
.line 8
.line 9
const-string v2, "field \'"
.line 10
.line 11
invoke-direct {v0, v2}, Ljava/lang/StringBuilder;-><init>(Ljava/lang/String;)V
.line 12
.line 13
.line 14
check-cast p0, Ljava/lang/reflect/Field;
.line 15
.line 16
invoke-static {p0}, Lcom/google/gson/internal/reflect/ReflectionHelper;->c(Ljava/lang/reflect/Field;)Ljava/lang/String;
.line 17
.line 18
.line 19
move-result-object p0
.line 20
invoke-virtual {v0, p0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 21
.line 22
.line 23
invoke-virtual {v0, v1}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 24
.line 25
.line 26
invoke-virtual {v0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 27
.line 28
.line 29
move-result-object p0
.line 30
goto :goto_0
.line 31
:cond_0
instance-of v0, p0, Ljava/lang/reflect/Method;
.line 32
.line 33
if-eqz v0, :cond_1
.line 34
.line 35
check-cast p0, Ljava/lang/reflect/Method;
.line 36
.line 37
new-instance v0, Ljava/lang/StringBuilder;
.line 38
.line 39
invoke-virtual {p0}, Ljava/lang/reflect/Method;->getName()Ljava/lang/String;
.line 40
.line 41
.line 42
move-result-object v2
.line 43
invoke-direct {v0, v2}, Ljava/lang/StringBuilder;-><init>(Ljava/lang/String;)V
.line 44
.line 45
.line 46
invoke-static {p0, v0}, Lcom/google/gson/internal/reflect/ReflectionHelper;->a(Ljava/lang/reflect/AccessibleObject;Ljava/lang/StringBuilder;)V
.line 47
.line 48
.line 49
invoke-virtual {v0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 50
.line 51
.line 52
move-result-object v0
.line 53
new-instance v2, Ljava/lang/StringBuilder;
.line 54
.line 55
const-string v3, "method \'"
.line 56
.line 57
invoke-direct {v2, v3}, Ljava/lang/StringBuilder;-><init>(Ljava/lang/String;)V
.line 58
.line 59
.line 60
invoke-virtual {p0}, Ljava/lang/reflect/Method;->getDeclaringClass()Ljava/lang/Class;
.line 61
.line 62
.line 63
move-result-object p0
.line 64
invoke-virtual {p0}, Ljava/lang/Class;->getName()Ljava/lang/String;
.line 65
.line 66
.line 67
move-result-object p0
.line 68
invoke-virtual {v2, p0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 69
.line 70
.line 71
const-string p0, "#"
.line 72
.line 73
invoke-virtual {v2, p0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 74
.line 75
.line 76
invoke-virtual {v2, v0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 77
.line 78
.line 79
invoke-virtual {v2, v1}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 80
.line 81
.line 82
invoke-virtual {v2}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 83
.line 84
.line 85
move-result-object p0
.line 86
goto :goto_0
.line 87
:cond_1
instance-of v0, p0, Ljava/lang/reflect/Constructor;
.line 88
.line 89
if-eqz v0, :cond_2
.line 90
.line 91
new-instance v0, Ljava/lang/StringBuilder;
.line 92
.line 93
const-string v2, "constructor \'"
.line 94
.line 95
invoke-direct {v0, v2}, Ljava/lang/StringBuilder;-><init>(Ljava/lang/String;)V
.line 96
.line 97
.line 98
check-cast p0, Ljava/lang/reflect/Constructor;
.line 99
.line 100
invoke-static {p0}, Lcom/google/gson/internal/reflect/ReflectionHelper;->b(Ljava/lang/reflect/Constructor;)Ljava/lang/String;
.line 101
.line 102
.line 103
move-result-object p0
.line 104
invoke-virtual {v0, p0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 105
.line 106
.line 107
invoke-virtual {v0, v1}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 108
.line 109
.line 110
invoke-virtual {v0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 111
.line 112
.line 113
move-result-object p0
.line 114
goto :goto_0
.line 115
:cond_2
new-instance v0, Ljava/lang/StringBuilder;
.line 116
.line 117
const-string v1, "<unknown AccessibleObject> "
.line 118
.line 119
invoke-direct {v0, v1}, Ljava/lang/StringBuilder;-><init>(Ljava/lang/String;)V
.line 120
.line 121
.line 122
invoke-virtual {p0}, Ljava/lang/Object;->toString()Ljava/lang/String;
.line 123
.line 124
.line 125
move-result-object p0
.line 126
invoke-virtual {v0, p0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 127
.line 128
.line 129
invoke-virtual {v0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 130
.line 131
.line 132
move-result-object p0
.line 133
:goto_0
if-eqz p1, :cond_3
.line 134
.line 135
const/4 p1, 0x0
.line 136
invoke-virtual {p0, p1}, Ljava/lang/String;->charAt(I)C
.line 137
.line 138
.line 139
move-result v0
.line 140
invoke-static {v0}, Ljava/lang/Character;->isLowerCase(C)Z
.line 141
.line 142
.line 143
move-result v0
.line 144
if-eqz v0, :cond_3
.line 145
.line 146
new-instance v0, Ljava/lang/StringBuilder;
.line 147
.line 148
invoke-direct {v0}, Ljava/lang/StringBuilder;-><init>()V
.line 149
.line 150
.line 151
invoke-virtual {p0, p1}, Ljava/lang/String;->charAt(I)C
.line 152
.line 153
.line 154
move-result p1
.line 155
invoke-static {p1}, Ljava/lang/Character;->toUpperCase(C)C
.line 156
.line 157
.line 158
move-result p1
.line 159
invoke-virtual {v0, p1}, Ljava/lang/StringBuilder;->append(C)Ljava/lang/StringBuilder;
.line 160
.line 161
.line 162
const/4 p1, 0x1
.line 163
invoke-virtual {p0, p1}, Ljava/lang/String;->substring(I)Ljava/lang/String;
.line 164
.line 165
.line 166
move-result-object p0
.line 167
invoke-virtual {v0, p0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 168
.line 169
.line 170
invoke-virtual {v0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 171
.line 172
.line 173
move-result-object p0
.line 174
:cond_3
return-object p0
.end method
.method public static e(Ljava/lang/Class;Ljava/lang/reflect/Field;)Ljava/lang/reflect/Method;
.locals 1
.line 1
sget-object v0, Lcom/google/gson/internal/reflect/ReflectionHelper;->a:Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;
.line 2
.line 3
invoke-virtual {v0, p0, p1}, Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;->a(Ljava/lang/Class;Ljava/lang/reflect/Field;)Ljava/lang/reflect/Method;
.line 4
.line 5
.line 6
move-result-object p0
.line 7
return-object p0
.end method
.method public static f(Ljava/lang/Class;)Ljava/lang/reflect/Constructor;
.locals 1
.line 1
sget-object v0, Lcom/google/gson/internal/reflect/ReflectionHelper;->a:Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;
.line 2
.line 3
invoke-virtual {v0, p0}, Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;->b(Ljava/lang/Class;)Ljava/lang/reflect/Constructor;
.line 4
.line 5
.line 6
move-result-object p0
.line 7
return-object p0
.end method
.method public static g(Ljava/lang/Exception;)Ljava/lang/String;
.locals 2
.line 1
invoke-virtual {p0}, Ljava/lang/Object;->getClass()Ljava/lang/Class;
.line 2
.line 3
.line 4
move-result-object v0
.line 5
invoke-virtual {v0}, Ljava/lang/Class;->getName()Ljava/lang/String;
.line 6
.line 7
.line 8
move-result-object v0
.line 9
const-string v1, "java.lang.reflect.InaccessibleObjectException"
.line 10
.line 11
invoke-virtual {v0, v1}, Ljava/lang/String;->equals(Ljava/lang/Object;)Z
.line 12
.line 13
.line 14
move-result v0
.line 15
if-eqz v0, :cond_1
.line 16
.line 17
invoke-virtual {p0}, Ljava/lang/Throwable;->getMessage()Ljava/lang/String;
.line 18
.line 19
.line 20
move-result-object p0
.line 21
if-eqz p0, :cond_0
.line 22
.line 23
const-string v0, "to module com.google.gson"
.line 24
.line 25
invoke-virtual {p0, v0}, Ljava/lang/String;->contains(Ljava/lang/CharSequence;)Z
.line 26
.line 27
.line 28
move-result p0
.line 29
if-eqz p0, :cond_0
.line 30
.line 31
const-string p0, "reflection-inaccessible-to-module-gson"
.line 32
.line 33
goto :goto_0
.line 34
:cond_0
const-string p0, "reflection-inaccessible"
.line 35
.line 36
:goto_0
new-instance v0, Ljava/lang/StringBuilder;
.line 37
.line 38
const-string v1, "\nSee "
.line 39
.line 40
invoke-direct {v0, v1}, Ljava/lang/StringBuilder;-><init>(Ljava/lang/String;)V
.line 41
.line 42
.line 43
const-string v1, "https://github.com/google/gson/blob/main/Troubleshooting.md#"
.line 44
.line 45
invoke-virtual {v1, p0}, Ljava/lang/String;->concat(Ljava/lang/String;)Ljava/lang/String;
.line 46
.line 47
.line 48
move-result-object p0
.line 49
invoke-virtual {v0, p0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 50
.line 51
.line 52
invoke-virtual {v0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 53
.line 54
.line 55
move-result-object p0
.line 56
return-object p0
.line 57
:cond_1
const-string p0, ""
.line 58
.line 59
return-object p0
.end method
.method public static h(Ljava/lang/Class;)[Ljava/lang/String;
.locals 1
.line 1
sget-object v0, Lcom/google/gson/internal/reflect/ReflectionHelper;->a:Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;
.line 2
.line 3
invoke-virtual {v0, p0}, Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;->c(Ljava/lang/Class;)[Ljava/lang/String;
.line 4
.line 5
.line 6
move-result-object p0
.line 7
return-object p0
.end method
.method public static i(Ljava/lang/Class;)Z
.locals 1
.line 1
sget-object v0, Lcom/google/gson/internal/reflect/ReflectionHelper;->a:Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;
.line 2
.line 3
invoke-virtual {v0, p0}, Lcom/google/gson/internal/reflect/ReflectionHelper$RecordHelper;->d(Ljava/lang/Class;)Z
.line 4
.line 5
.line 6
move-result p0
.line 7
return p0
.end method
.method public static j(Ljava/lang/reflect/AccessibleObject;)V
.locals 4
.line 1
const/4 v0, 0x1
.line 2
:try_start_0
invoke-virtual {p0, v0}, Ljava/lang/reflect/AccessibleObject;->setAccessible(Z)V
:try_end_0
.catch Ljava/lang/Exception; {:try_start_0 .. :try_end_0} :catch_0
.line 3
.line 4
.line 5
return-void
.line 6
:catch_0
move-exception v0
.line 7
const/4 v1, 0x0
.line 8
invoke-static {p0, v1}, Lcom/google/gson/internal/reflect/ReflectionHelper;->d(Ljava/lang/reflect/AccessibleObject;Z)Ljava/lang/String;
.line 9
.line 10
.line 11
move-result-object p0
.line 12
new-instance v1, Lcom/google/gson/JsonIOException;
.line 13
.line 14
const-string v2, "Failed making "
.line 15
.line 16
const-string v3, " accessible; either increase its visibility or write a custom TypeAdapter for its declaring type."
.line 17
.line 18
invoke-static {v2, p0, v3}, Landroid/support/v4/media/a;->w(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 19
.line 20
.line 21
move-result-object p0
.line 22
invoke-static {v0}, Lcom/google/gson/internal/reflect/ReflectionHelper;->g(Ljava/lang/Exception;)Ljava/lang/String;
.line 23
.line 24
.line 25
move-result-object v2
.line 26
invoke-virtual {p0, v2}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;
.line 27
.line 28
.line 29
invoke-virtual {p0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;
.line 30
.line 31
.line 32
move-result-object p0
.line 33
invoke-direct {v1, p0, v0}, Ljava/lang/RuntimeException;-><init>(Ljava/lang/String;Ljava/lang/Throwable;)V
.line 34
.line 35
.line 36
throw v1
.end method