KaKi87/deepl-scraper
1
0
Fork 1
Code Issues 1 Pull requests 1 Releases Wiki Activity

Add glossary methods #4

Open
KaKi87 wants to merge 15 commits from Androz2091/deepl-scraper:glossary-v2 into master
pull from: Androz2091/deepl-scraper:glossary-v2
merge into: KaKi87:master
Conversation 3 Commits 15 Files changed 3 +170 -3
KaKi87 commented 2021-02-18 17:02:26 +01:00
Owner
Copy link
No description provided.
KaKi87 added 1 commit 2021-02-18 17:02:31 +01:00
Androz2091 added 1 commit 2021-02-18 17:03:38 +01:00
Androz2091 commented 2021-02-18 17:05:52 +01:00
First-time contributor
Copy link
  • clearGlossary doesn't work. Actually it works in my browser (when I run the script manually), but it doesn't work using Puppeteer. I tried to run the browser with the headless mode disabled to debug but my puppeteer browser is constantly crashing with headless mode disabled I don't know why and it's not due to deepl-scraper but I can't debug by disabling the headless mode
* `clearGlossary` doesn't work. Actually it works in my browser (when I run the script manually), but it doesn't work using Puppeteer. I tried to run the browser with the headless mode disabled to debug but my puppeteer browser is constantly crashing with headless mode disabled *I don't know why and it's not due to deepl-scraper but I can't debug by disabling the headless mode*
KaKi87 commented 2021-02-18 17:25:29 +01:00
Author
Owner
Copy link
  • Please allow the user to set language parameters in lowercase
  • Please remove console calls
  • Please regroup all constant declarations that can be
  • Please don't use page.evaluate
    • Please replace document.querySelectorAll(selector) by await page.$$(selector)
    • Please replace element.textContent by await (await element.getProperty('textContent')).jsonValue()

Doing this could also help you fix clearGlossary.

I can't debug by disabling the headless mode

Can you elaborate more on this ?

Feel free to ask if you have more trouble with puppeteer.

- Please allow the user to set language parameters in lowercase - Please remove `console` calls - Please regroup all constant declarations that can be - Please don't use `page.evaluate` - Please replace `document.querySelectorAll(selector)` by `await page.$$(selector)` - Please replace `element.textContent` by `await (await element.getProperty('textContent')).jsonValue()` Doing this could also help you fix `clearGlossary`. > I can't debug by disabling the headless mode Can you elaborate more on this ? Feel free to ask if you have more trouble with puppeteer.
Androz2091 added 1 commit 2021-02-18 17:37:52 +01:00
Androz2091 added 1 commit 2021-02-18 17:38:25 +01:00
Androz2091 added 1 commit 2021-02-18 17:39:12 +01:00
KaKi87 commented 2021-02-18 18:01:51 +01:00
Author
Owner
Copy link

Please upate documentation as per ee988e5.

Please upate documentation as per ee988e5.
KaKi87 added 1 commit 2021-03-06 21:15:01 +01:00
Androz2091 added 10 commits 2021-03-18 17:13:54 +01:00 
Reviewed-on: Androz2091/deepl-scraper#1
This pull request has changes conflicting with the target branch.
  • index.js
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u glossary-v2:Androz2091-glossary-v2
git checkout Androz2091-glossary-v2

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master
git merge --no-ff Androz2091-glossary-v2
git checkout Androz2091-glossary-v2
git rebase master
git checkout master
git merge --ff-only Androz2091-glossary-v2
git checkout Androz2091-glossary-v2
git rebase master
git checkout master
git merge --no-ff Androz2091-glossary-v2
git checkout master
git merge --squash Androz2091-glossary-v2
git checkout master
git merge --ff-only Androz2091-glossary-v2
git checkout master
git merge Androz2091-glossary-v2
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: KaKi87/deepl-scraper#4
No description provided.
Delete branch "Androz2091/deepl-scraper:glossary-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?